Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

@richardhuaaa
Copy link
Contributor

(Add ?w=1 to the URL on the diff view to ignore whitespace changes)

This is an optional PR in preparation for the upcoming breaking server changes. Each of the following pieces have been individually code reviewed, but the merging of features from master has not. Any comments, or especially help with validation, would be very much appreciated.

  1. Cookie-less/session-less authentication. Instead of retrieving a cookie from the /auth/login/accessKey endpoint, we send the access key with each request using the Authorization header, similarly to how OAuth works.
  2. Use names instead of ID's at REST endpoints. Basically moved name resolution logic from the CLI into the server.
  3. Adopt other API simplifications. Change all PUT routes to PATCH routes. Add 'key' property to Deployment object and remove DeploymentKey endpoints. Change PUT /package route to POST /release.
  4. SDK cleanup. Including significant refactoring, and URL encoding all REST inputs.

Richard Hua added 30 commits January 7, 2016 16:51
Cookieless header-based authentication
Remove DeploymentKey object and fetch key directly off Deployments
constructor(accessKey: string, userAgent?: string, serverUrl?: string) {
this._accessKey = accessKey;
this._userAgent = userAgent;
this._serverUrl = serverUrl || "https://codepush.azurewebsites.net";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this default to https://codepush-management.azurewebsites.net to reflect the splitting off of a new management server from the old acquisition server.

richardhuaaa pushed a commit that referenced this pull request Feb 23, 2016
Reflect breaking server changes on the client
@richardhuaaa richardhuaaa merged commit d90f6e5 into master Feb 23, 2016
@richardhuaaa richardhuaaa deleted the breaking branch April 12, 2016 22:51
@richardhuaaa richardhuaaa restored the breaking branch April 12, 2016 22:51
@richardhuaaa richardhuaaa deleted the breaking branch April 12, 2016 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants