This repository was archived by the owner on May 20, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 530
Reflect breaking server changes on the client #140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cookieless header-based authentication
Also some additional refactoring.
Remove DeploymentKey object and fetch key directly off Deployments
…ification Move name resolution logic out of the CLI
Breaking changes loose ends
Rely on server for generation of qualified app names
sdk/script/account-manager.ts
Outdated
| constructor(accessKey: string, userAgent?: string, serverUrl?: string) { | ||
| this._accessKey = accessKey; | ||
| this._userAgent = userAgent; | ||
| this._serverUrl = serverUrl || "https://codepush.azurewebsites.net"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this default to https://codepush-management.azurewebsites.net to reflect the splitting off of a new management server from the old acquisition server.
richardhuaaa
pushed a commit
that referenced
this pull request
Feb 23, 2016
Reflect breaking server changes on the client
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Add ?w=1 to the URL on the diff view to ignore whitespace changes)
This is an optional PR in preparation for the upcoming breaking server changes. Each of the following pieces have been individually code reviewed, but the merging of features from master has not. Any comments, or especially help with validation, would be very much appreciated.
/auth/login/accessKeyendpoint, we send the access key with each request using theAuthorizationheader, similarly to how OAuth works./packageroute to POST/release.